Relax AsyncSequence.collect availability check #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Tests currently fail with: > grpc-swift/Tests/GRPCTests/GRPCAsyncClientCallTests.swift:374:61: error: 'collect()' is only available in macOS 12 or newer Modifications: Relax the availability check on the `AsyncSequence` extension. It seems to arise from the constraint on `AsyncSequence.reduce(into: Result)` which only requires 10.15, not 12. Result: Tests should pass.
glbrntt
approved these changes
Jun 16, 2023
WendellXY
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
Motivation: Tests currently fail with: > grpc-swift/Tests/GRPCTests/GRPCAsyncClientCallTests.swift:374:61: error: 'collect()' is only available in macOS 12 or newer Modifications: Relax the availability check on the `AsyncSequence` extension. It seems to arise from the constraint on `AsyncSequence.reduce(into: Result)` which only requires 10.15, not 12. Result: Tests should pass.
pinlin168
pushed a commit
to sundayfun/grpc-swift
that referenced
this pull request
Aug 24, 2023
Motivation: Tests currently fail with: > grpc-swift/Tests/GRPCTests/GRPCAsyncClientCallTests.swift:374:61: error: 'collect()' is only available in macOS 12 or newer Modifications: Relax the availability check on the `AsyncSequence` extension. It seems to arise from the constraint on `AsyncSequence.reduce(into: Result)` which only requires 10.15, not 12. Result: Tests should pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Tests currently fail with:
Modifications:
Relax the availability check on the
AsyncSequenceextension. It seems to arise from the constraint onAsyncSequence.reduce(into: Result)which only requires 10.15, not 12.Result:
Tests should pass.