Skip to content

Allow a Status to be created from an HTTP status code #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions Sources/GRPCCore/Status.swift
Original file line number Diff line number Diff line change
Expand Up @@ -296,3 +296,32 @@ extension Status.Code {
/// operation.
public static let unauthenticated = Self(code: .unauthenticated)
}

extension Status {
/// Create a status from an HTTP status code for a response which didn't include a gRPC status.
///
/// - Parameter httpStatusCode: The HTTP status code to map to a status.
public init(httpStatusCode: Int) {
// See the "http-grpc-status-mapping.md" doc in grpc/grpc GitHub repo.
switch httpStatusCode {
case 400:
self = Status(code: .internalError, message: "HTTP 400: Bad Request")
case 401:
self = Status(code: .unauthenticated, message: "HTTP 401: Unauthorized")
case 403:
self = Status(code: .permissionDenied, message: "HTTP 403: Forbidden")
case 404:
self = Status(code: .unimplemented, message: "HTTP 404: Not Found")
case 429:
self = Status(code: .unavailable, message: "HTTP 429: Too Many Requests")
case 502:
self = Status(code: .unavailable, message: "HTTP 502: Bad Gateway")
case 503:
self = Status(code: .unavailable, message: "HTTP 503: Service Unavailable")
case 504:
self = Status(code: .unavailable, message: "HTTP 504: Gateway Timeout")
default:
self = Status(code: .unknown, message: "HTTP \(httpStatusCode)")
}
}
}
19 changes: 19 additions & 0 deletions Tests/GRPCCoreTests/StatusTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,23 @@ struct StatusTests {
func fitsInExistentialContainer() {
#expect(MemoryLayout<Status>.size <= 24)
}

@Test(
"From HTTP status code",
arguments: [
(400, Status(code: .internalError, message: "HTTP 400: Bad Request")),
(401, Status(code: .unauthenticated, message: "HTTP 401: Unauthorized")),
(403, Status(code: .permissionDenied, message: "HTTP 403: Forbidden")),
(404, Status(code: .unimplemented, message: "HTTP 404: Not Found")),
(429, Status(code: .unavailable, message: "HTTP 429: Too Many Requests")),
(502, Status(code: .unavailable, message: "HTTP 502: Bad Gateway")),
(503, Status(code: .unavailable, message: "HTTP 503: Service Unavailable")),
(504, Status(code: .unavailable, message: "HTTP 504: Gateway Timeout")),
(418, Status(code: .unknown, message: "HTTP 418")),
]
)
func convertFromHTTPStatusCode(code: Int, expected: Status) {
let status = Status(httpStatusCode: code)
#expect(status == expected)
}
}
Loading