Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grpc-swift-protobuf version in hello-world example #2186

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix grpc-swift-protobuf version in hello-world example #2186

merged 1 commit into from
Jan 29, 2025

Conversation

gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Jan 28, 2025

CI is currently failing to build because grpc-swift-protobuf's dependency on the hello-world example points to no a non-existing tag.

@gjcairo gjcairo added the semver/none No version bump required. label Jan 28, 2025
@gjcairo gjcairo requested a review from glbrntt January 28, 2025 22:39
glbrntt
glbrntt approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@glbrntt glbrntt merged commit f1a8497 into grpc:main Jan 29, 2025
28 of 30 checks passed
@gjcairo gjcairo deleted the fix-example-build branch January 29, 2025 11:53
@BrewTestBot BrewTestBot mentioned this pull request Jan 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjcairo @glbrntt