Skip to content

datatypes: Handle missing optional lists and objects #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

irgolic
Copy link
Contributor

@irgolic irgolic commented Dec 7, 2023

Fix #489

@victai, could you please check if this PR fixes your issue?

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
guardrails ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 3:15pm

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@82b4a2e). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage        ?   81.18%           
=======================================
  Files           ?       45           
  Lines           ?     4559           
  Branches        ?        0           
=======================================
  Hits            ?     3701           
  Misses          ?      858           
  Partials        ?        0           
Flag Coverage Δ
unittests 81.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zsimjee zsimjee changed the base branch from main to 0.3.0 December 7, 2023 18:07
@irgolic irgolic closed this Dec 7, 2023
@victai
Copy link

victai commented Dec 9, 2023

Yes, it's fixed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional keywords on Objects/List or any other Datatypes that wraps other BaseModel
5 participants