Skip to content

Failing to create merge request on gitlab. #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michalczaplinski opened this issue Mar 2, 2017 · 1 comment
Closed

Failing to create merge request on gitlab. #131

michalczaplinski opened this issue Mar 2, 2017 · 1 comment
Assignees
@guyzmo
Labels
blocking bug

Comments

@michalczaplinski
Copy link 

git lab request create user/my-repo myfeature master 'My neat feature' -m 'So much to say about that feature…'

fails with:

Fatal error: request_create() takes from 6 to 8 positional arguments but 9 were given
@guyzmo
Copy link
Owner

guyzmo commented Mar 2, 2017

here's my reaction to that:

  1. WTF, 😲
  2. OMFG, 😲
  3. Shame on me 😑

looking into it, and making sure all arguments are well tested.
I have to admit I'm having a hard time figuring out the right amount of automagic is needed to make the request create command work.

@guyzmo guyzmo self-assigned this Mar 2, 2017
Crazybus pushed a commit to Crazybus/git-repo that referenced this issue Mar 5, 2017
Fix gitlab merge request by supporting the edit option. Fixes guyzmo#131
80101db
@guyzmo guyzmo closed this as completed in 619b359 Apr 28, 2017
guyzmo added a commit that referenced this issue Apr 28, 2017
@guyzmo
Merge branch requests/github/132 into devel
32a9db6 
fixes #131
fixes #132
@guyzmo guyzmo removed the backlog label Apr 28, 2017
guyzmo added a commit that referenced this issue May 8, 2017
@guyzmo
👍 Merge branch 'devel' ; 🔖 Version bump to 1.10.0 🎂
70732ff 
First anniversary release 🎂

This release marks the first anniversary
and 10th release of git-repo 🎉

Now git-repo supports 6 git services:

  github, gitlab, bitbucket,
  gogs, gitea and gitbucket

It supports the following commands:

  clone, fork, create, delete,
  add, open, ls, request, gist

And it's becoming relatively stable
(keep sending bug reports 🙏)

♥ Contributors

Thanks to @kounoike for the gitbucket support 🙌

Now there are three contributors promoted to collaborators:

* @kounoike, @pyhedgehog and @Crazybus

🚧 Features

* When add has no parameters, add default remote #100 #141
* When add has 'upstream' parameter, add the upstream remote #99 #141
* Use default branch instead of hardcoded 'master' #91
* Refactor and complete bitbucket support #43 #11 #80 #14 #89 #90 #79
* Loosen versions of dependencies #133
* Report if the service is already setup #136
* Adds GitBucket support #142 #144
* Adds support for ssh:// URL #148

🚒 Bugfixes

* fix various crashes #152
* fix gitlab clone crash #129
* fix request create command #147 #127
* fix request fetch command #138 #131
* fix wizard crash #149
* fix mishandling of renamed gitlab project urls #137

📝 Documentation

* documentation #145

Signed-off-by: Guyzmo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyzmo guyzmo

Labels
blocking bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guyzmo @michalczaplinski