Skip to content

always return sub value #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Janim007
Copy link

@Janim007 Janim007 commented Aug 5, 2021

python sub method always return the original value even if there was no match and replacement.
to be consistent with python, this PR propose to remove checking if value hasn't changed and return the original value as it as.
example:

>>> re.sub(r'foo', 'bar', 'github')
'github'

@michaelmior
Copy link
Collaborator

@Janim007 Is there a specific problem this causes in the existing code? Could you add a test for such a case?

@torbenw
Copy link

torbenw commented Dec 4, 2024

@michaelmior I have some examples for why I think the current behavior is a problem:

Exp: orders[*].type
Res: [('orders.[0].type', 'type-1'), ('orders.[1].type', 'type-2')]

Exp: orders[*].type.`sub(/type-1/, Type1)`
Res: [('`this`', 'Type1')]

Exp: orders[*].type.`sub(/type-2/, Type2)`
Res: [('`this`', 'Type2')]

Exp: orders[*].type.`sub(/type-1/, Type1)`.`sub(/type-2/, Type2)`
Res: []

Exp: orders[*].type.`sub(/type-1/, Type1)`.`sub(/Type1/, Type1-1)`
Res: [('`this`', 'Type1-1')]

Exp: orders[*].type.`sub(/type-9999/, Type9999)`
Res: []

If I want to do a replacement for 1 of the values I will not get any of the other values.
If I want to do a replacement with different replacement strings for more than 1 value that is also not be possible.
If I use a regex with no match in my results (type-9999) I will not get any values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants