-
Notifications
You must be signed in to change notification settings - Fork 12.3k
Tell users that IE 8 and 9 are outdated #1748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hurrah. Wonderful stuff. IE10 is definitely a stack load more modern than IE9, but just to play Devil's Advocate: Why is a user not told that IE10 is "Outdated"? Consider all of the OS's that Microsoft still have listed under "Mainstream Support": Windows 7 came with IE9 and is upgradable to IE11. Just wondering. Thanks. |
IE 10 doesn't support conditional comments. So even if we wanted to tell users it's outdated, we couldn't, not without doing some UA sniffing with ECMAScript. |
Ah. That would be a very good reason indeed! |
@alrra 👀 |
@alrra 👀 |
🐹 @QWp6t Can you also:
Thanks! Note: This should be merge as part of |
Previous part of the discussion: #1748. |
Is this going to be merged? |
It'd prefer if this used "lte IE 9" so it's clear that IE10 users are not caught. |
@paulirish I went ahead and implemented |
Closing in favor of #1892. |
@QWp6t Are you voting in favor of no "browsehappy" at all, then? |
Yeah, exactly. And for bumping up jQuery version and dropping html5-shiv. I'm in favor of completely dropping support for IE 8 and 9. 👍 |
@QWp6t Would love to hear your reasoning 👍 Also, if there's a push to drop IE8 and 9, should we consider dropping |
After chewing on it, I'm going to reopen this and pull it into #1892 since IE9 will still be supported and this isn't all that much code. |
@QWp6t Hey, as I mentioned above, I think keeping the browsehappy block makes sense. I do want to upgrade it to the |
Oh, I had deleted it because you closed this PR, so I assumed that meant you were going a different direction. My bad. I restored the branch. Does that work for you? Or do you need a new PR? I also gave you commit access to the branch, if that helps at all. |
@QWp6t sorry about the confusion. I just took a look at the PR as it's currently configured and it's a little messy. I think it would be cleaner to just get the changes anew. |
@roblarsen I rebased (again, lol). It should be good now. If not, then feel free to just close; it's such a minor change that I'm not too concerned about getting credit for it. lol |
Thanks! |
Yay! 🎉 |
Hmm. |
I think this is a good idea, so here's a PR.
To be clear, this isn't dropping support for IE 8 and 9. This is simply informing users that their older browsers are outdated. This will hopefully promote an increased rate of browser upgrades so that we can eventually drop support once usage falls below whatever threshold we've established.