Skip to content

Tell users that IE 8 and 9 are outdated #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2016
Merged

Tell users that IE 8 and 9 are outdated #1748

merged 1 commit into from
Sep 13, 2016

Conversation

QWp6t
Copy link
Contributor

@QWp6t QWp6t commented Nov 2, 2015

I think this is a good idea, so here's a PR.

To be clear, this isn't dropping support for IE 8 and 9. This is simply informing users that their older browsers are outdated. This will hopefully promote an increased rate of browser upgrades so that we can eventually drop support once usage falls below whatever threshold we've established.

@JohnnyWalkerDigital
Copy link

Hurrah. Wonderful stuff. IE10 is definitely a stack load more modern than IE9, but just to play Devil's Advocate: Why is a user not told that IE10 is "Outdated"?

Consider all of the OS's that Microsoft still have listed under "Mainstream Support":

Windows 7 came with IE9 and is upgradable to IE11.
Windows 8 came with IE10 and is upgradable to IE11.
Windows 8.1 came with IE11.
Windows 10 comes with Edge.

Just wondering. Thanks.

@QWp6t
Copy link
Contributor Author

QWp6t commented Nov 3, 2015

IE 10 doesn't support conditional comments. So even if we wanted to tell users it's outdated, we couldn't, not without doing some UA sniffing with ECMAScript.

@JohnnyWalkerDigital
Copy link

Ah. That would be a very good reason indeed!

@QWp6t
Copy link
Contributor Author

QWp6t commented Jan 7, 2016

@alrra 👀

@QWp6t
Copy link
Contributor Author

QWp6t commented Jan 9, 2016

@alrra 👀

@alrra
Copy link
Member

alrra commented Jan 9, 2016

@alrra 👀

🐹

@QWp6t Can you also:

  • update the docs (see: html.md)
  • update the commit message to include a little bit more information about why this change was made, while also including some official links
  • squash the commits into a single one

Thanks!

Note: This should be merge as part of v6.0.0, and it solves some of the points from #1524.

@alrra
Copy link
Member

alrra commented Jan 10, 2016

Previous part of the discussion: #1748.

@JohnnyWalkerDigital
Copy link

Is this going to be merged?

@paulirish
Copy link
Member

It'd prefer if this used "lte IE 9" so it's clear that IE10 users are not caught.
I'm sure many devs forget that ie10 dropped support for CC.

@QWp6t QWp6t closed this Aug 8, 2016
@QWp6t QWp6t reopened this Aug 8, 2016
@QWp6t
Copy link
Contributor Author

QWp6t commented Aug 8, 2016

@paulirish I went ahead and implemented lte IE 9, pulled upstream changes so that there wouldn't be merge conflicts with the changelog, and then rebased.

@roblarsen roblarsen mentioned this pull request Aug 24, 2016
@QWp6t
Copy link
Contributor Author

QWp6t commented Aug 24, 2016

Closing in favor of #1892.

@QWp6t QWp6t closed this Aug 24, 2016
@roblarsen
Copy link
Member

@QWp6t Are you voting in favor of no "browsehappy" at all, then?

@QWp6t
Copy link
Contributor Author

QWp6t commented Aug 24, 2016

Yeah, exactly. And for bumping up jQuery version and dropping html5-shiv. I'm in favor of completely dropping support for IE 8 and 9. 👍

@JohnnyWalkerDigital
Copy link

JohnnyWalkerDigital commented Aug 24, 2016

@QWp6t Would love to hear your reasoning 👍

Also, if there's a push to drop IE8 and 9, should we consider dropping X-UA-Compatible? IE10 would be the only browser left that uses it, and it has similar levels of popularity as IE8 and 9 (it's actually the least popular of the three). No version of Windows that supports IE10 doesn't support IE11.

See also: http://stackoverflow.com/a/26348511/199700

@roblarsen roblarsen reopened this Sep 1, 2016
@roblarsen
Copy link
Member

After chewing on it, I'm going to reopen this and pull it into #1892 since IE9 will still be supported and this isn't all that much code.

@roblarsen roblarsen closed this Sep 12, 2016
@QWp6t QWp6t deleted the ie9-outdated branch September 12, 2016 17:52
@roblarsen
Copy link
Member

@QWp6t Hey, as I mentioned above, I think keeping the browsehappy block makes sense. I do want to upgrade it to the lte 9 you had here. With this branch deleted I can't pull your work in. If you'd like the credit, feel free to open another PR based off of the latest master. If you don't care, I can recreate your work easily enough, but I like to make sure folks get credit.

@QWp6t QWp6t restored the ie9-outdated branch September 13, 2016 01:33
@QWp6t
Copy link
Contributor Author

QWp6t commented Sep 13, 2016

Oh, I had deleted it because you closed this PR, so I assumed that meant you were going a different direction. My bad. I restored the branch. Does that work for you? Or do you need a new PR?

I also gave you commit access to the branch, if that helps at all.

@roblarsen roblarsen reopened this Sep 13, 2016
@roblarsen
Copy link
Member

@QWp6t sorry about the confusion. I just took a look at the PR as it's currently configured and it's a little messy. I think it would be cleaner to just get the changes anew.

@QWp6t
Copy link
Contributor Author

QWp6t commented Sep 13, 2016

@roblarsen I rebased (again, lol). It should be good now. If not, then feel free to just close; it's such a minor change that I'm not too concerned about getting credit for it. lol

@roblarsen roblarsen merged commit a2356c1 into h5bp:master Sep 13, 2016
@roblarsen
Copy link
Member

Thanks!

@QWp6t QWp6t deleted the ie9-outdated branch September 13, 2016 02:37
@QWp6t
Copy link
Contributor Author

QWp6t commented Sep 13, 2016

Yay! 🎉

@JohnnyWalkerDigital
Copy link

Hmm.

jeffreznik pushed a commit to jeffreznik/sw-test that referenced this pull request Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants