Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Normalize #2960

Merged
merged 4 commits into from
Aug 31, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,22 +85,16 @@ Choose one of the following options:
research and experimentation by over 200 contributors.
* Designed with progressive enhancement in mind.
* Includes:
* [`Normalize.css`](https://necolas.github.io/normalize.css/)
for CSS normalizations and common bug fixes.
* A custom build of [`Modernizr`](https://modernizr.com/) for feature
detection.
* [`Apache Server Configs`](https://github.com/h5bp/server-configs-apache)
that improve the web site's performance and security.
* Placeholder Open Graph elements and attributes.
* An example package.json file with [WebPack](https://webpack.js.org/) commands
* Placeholder Open Graph elements and attributes.
* An example package.json file with [WebPack](https://webpack.js.org/) commands
built in to jumpstart application development.
* Placeholder CSS Media Queries.
* Useful CSS helper classes.
* Default print styles, performance optimized.
* Protection against any stray `console` statements causing JavaScript
errors in older browsers.
* "Delete-key friendly." Easy to strip out parts you don't need.
* Extensive documentation.
* Placeholder CSS Media Queries.
* Useful CSS helper classes.
* Default print styles, performance optimized.
* "Delete-key friendly." Easy to strip out parts you don't need.
* Extensive documentation.

## Browser Support

Expand Down
8 changes: 4 additions & 4 deletions dist/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
},
"devDependencies": {
"copy-webpack-plugin": "^11.0.0",
"html-webpack-plugin": "^5.5.0",
"webpack": "^5.74.0",
"webpack-cli": "^4.10.0",
"webpack-dev-server": "^4.11.1",
"html-webpack-plugin": "^5.5.1",
"webpack": "^5.81.0",
"webpack-cli": "^5.0.2",
"webpack-dev-server": "^4.13.3",
"webpack-merge": "^5.8.0"
}
}
8 changes: 1 addition & 7 deletions gulpfile.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,6 @@ gulp.task('copy:misc', () =>
}).pipe(gulp.dest(dirs.dist))
);

gulp.task('copy:normalize', () =>
gulp.src('node_modules/normalize.css/normalize.css')
.pipe(gulp.dest(`${dirs.dist}/css`))
);

gulp.task('modernizr', (done) => {
// TODO: rework this flow instead of just reacting to the fact that the jQuery step is gone
if (!fs.existsSync(`${dirs.dist}/js/vendor/`)){
Expand Down Expand Up @@ -149,8 +144,7 @@ gulp.task(
'copy:index.html',
'copy:license',
'copy:style',
'copy:misc',
'copy:normalize'
'copy:misc'
)
);

Expand Down
13 changes: 0 additions & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"main.css": "3.0.0",
"mocha": "^10.2.0",
"modernizr": "3.12.0",
"normalize.css": "8.0.1",
"strip-json-comments": "^5.0.0"
},
"engines": {
Expand Down
1 change: 0 additions & 1 deletion test/file_existence.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ const expectedFilesInDistDir = [

'css/', // for directories, a `/` character
// should be included at the end
'css/normalize.css',
'css/style.css',

'favicon.ico',
Expand Down