Skip to content

Improve visibility of some UI elements #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

pkrasicki
Copy link

Partially fixes #1441. Increases contrast of some buttons. The color of line numbers wasn't changed in this PR, because it seems that it would require editing every theme separately.

codimd icons

codimd table of contents

@Yukaii Yukaii temporarily deployed to codimd-ui-contrast-bgqcoltedrl March 9, 2020 12:20 Inactive
@Yukaii
Copy link
Member

Yukaii commented Mar 9, 2020

Hi @pkrasicki Thanks for your contribution :) Remember to sign off your git commit with --signoff

@Yukaii Yukaii added this to the Next milestone Mar 9, 2020
@Yukaii Yukaii added the UI/UX label Mar 9, 2020
@Yukaii Yukaii temporarily deployed to codimd-ui-contrast-bgqcoltedrl March 9, 2020 12:27 Inactive
@pkrasicki
Copy link
Author

Done :).

@jackycute
Copy link
Member

jackycute commented Mar 10, 2020

Hi @pkrasicki,
I love the color changes of this PR, it looks better now.

However, the signoff you did for the commit is invalid for DCO ([omitted] is not valid for signoff). Could you provide a proper email address for signoff?

@Yukaii Yukaii temporarily deployed to codimd-ui-contrast-bgqcoltedrl March 10, 2020 09:11 Inactive
@pkrasicki
Copy link
Author

@jackycute I changed the commit message.

@jackycute
Copy link
Member

Thanks @pkrasicki

@jackycute jackycute merged commit af5ad36 into hackmdio:develop Mar 10, 2020
@Yukaii Yukaii modified the milestones: Next, 2.0.1 Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contrast is at certain parts too low
3 participants