Skip to content

Fix issue with SQlite connection #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix issue with SQlite connection #1879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f16120
Add index at revision table
yamashush Jan 14, 2024
280125c
style: lint fix
Yukaii Jun 5, 2024
3ed5c4d
Fix issue with SQlite connection
Aug 8, 2024
6c10551
Reduce npm install log
Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion deployments/docker-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,19 @@ if [[ "$#" -gt 0 ]]; then
exit $?
fi


# check database and redis is ready
pcheck -env CMD_DB_URL
if [[ $CMD_DB_URL != "sqlite"* ]] ;
then
pcheck -env CMD_DB_URL
fi

# Install sqlite3 if required
if [[ $CMD_DB_URL == "sqlite"* ]] ;
then
echo "Installing sqlite3 package..."
npm install -s sqlite3
fi

# run DB migrate
NEED_MIGRATE=${CMD_AUTO_MIGRATE:=true}
Expand Down
11 changes: 11 additions & 0 deletions lib/migrations/20240114120250-revision-add-index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
'use strict'

module.exports = {
up: (queryInterface, Sequelize) => {
return queryInterface.addIndex('Revisions', ['noteId'], {})
},

down: (queryInterface, Sequelize) => {
return queryInterface.removeIndex('Revisions', 'noteId')
Copy link
Preview

Copilot AI Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The down migration is attempting to remove an index using the name 'noteId', but the up migration does not explicitly name the index. Consider providing an explicit index name in queryInterface.addIndex so that removeIndex can reference the correct name.

Copilot uses AI. Check for mistakes.

}
}