ListView item text doesn't update

[TheBolliwood]

Expected Behavior

ListView displays the complete item array correctly.

Actual Behavior

ListView only displays the text of the initial items.

Steps to Reproduce the Problem

1. Do the Tutorial till the "Add Tasks" functionality
2. Type something into the textField (I typed foo, bar and baz)
3. The ListView only displays foo, but the console shows also bar and baz

Specifications

• tns Version: 6.0.2

Device 1:

• Android Version: 9.0 (Pie) - API 28
• Emulator Version: 29.0.9-5537588
• Kernel Version: Linux 5.0.0-21-generic x86_64
• Platform: Ubuntu 19.04

Device 2:

• Android Version: 9.0 (Pie) - API 28
• NativeScript Playground Version: 1.8.0
• NativeScript Preview Version: 1.23.0

Device 3:

• Android Version: 9.0 (Pie) - API 28
• Emulator Version: 29.0.11-5598178
• Kernel Version: Linux 4.15.0-48-generic x86_64
• Platform: Ubuntu 18.04 LTS

[halfnelson]

Thanks for this. Looks like svelte's dirty check generated code changed from 3.6.1 to 3.6.2 which causes the item text not to update. Not sure if that was intended and I need to fix svelte-native or whether it was unintended and I need to ticket against svelte. I'll investigate.

[halfnelson]

for reference the generated code went from

	p(changed, ctx) {
			if (default_slot && default_slot.p && (changed.$$scope || changed.props)) {
				default_slot.p(get_slot_changes(default_slot_1, ctx, changed, get_default_slot_changes), get_slot_context(default_slot_1, ctx, get_default_slot_context));
			}
		},

to

	if (default_slot && default_slot.p && changed.$$scope) {
				default_slot.p(get_slot_changes(default_slot_1, ctx, changed, get_default_slot_changes), get_slot_context(default_slot_1, ctx, get_default_slot_context));
			}

notice it no longer checks for changed.props which is what we are changing.

[halfnelson]

I have reproduced this bug in svelte 3.7.0, so in the short term to work around this, I will build a new svelte-native with 3.6.1. (the last working version)

[halfnelson]

Svelte bug for tracking sveltejs/svelte#3354

[halfnelson]

I have fixed this with svelte-native 0.4.1
ensure all references in package.json are to svelte 3.6.1