Skip to content

Inconsistent event emits #4184

Closed
Closed
@kanongil

Description

@kanongil

Support plan

  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: n/a
  • module version: 20.0.1
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...):
  • any other relevant information:

This is a followup from comment in #4173 (review).

What problem are you trying to solve?

Have a consistent event interface for Hapi, where event emits cannot delay / abort server processing.

Do you have a new or modified API suggestion to solve the problem?

Don't wait for emit() promise, on server "start" and "stop", and subsequently don't return a promise from events.emit(). This should also enable much better performance, especially for events with no listeners.

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking changesChange that can breaking existing codefeatureNew functionality or improvement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions