-
Notifications
You must be signed in to change notification settings - Fork 633
Simple .log not working for WireShark #1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Are you saying the issue is the two following lines? Lines 185 to 186 in 69a5209
|
No it's from the following two lines: Lines 182 to 183 in 69a5209
|
@jazi007 @felixdivo The change in question was merged into master here: 4d9b32c. The associated PR is here: #1244. |
Hi @j-c-cook , the direction is an optional information that can be enabled e.g. in
As you can see the optional The question is what did the Wireshark parser do that it is not capable to cope with such an extension?!? |
I suggest opening an issue at https://gitlab.com/wireshark/wireshark/-/issues |
|
Describe the bug
Since the update to version 4.1.0 the simple .log file cannot be loaded to Wireshark. If you try to import it generates stupid protocol errors, because the CAN protocol is not recognized.
To Reproduce
Send a message on a CAN bus and save the received messages to a .log file. Try to open it with WireShark.
Expected behavior
The .log file should be imported correctly and recognized as a CAN trace.
Additional context
OS and version: MacOS Montery 12.6.2
Python version: PYthon 3.9.2
python-can version: 4.1.0
python-can interface/s (if applicable): SocketCAN
The problem is caused by adding the direction of the message to the log file in line 185 of canutils.py.
The text was updated successfully, but these errors were encountered: