[IO][canutils]: add direction support #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazi007
force-pushed
the
canutils-io-add-dir-support
branch
from
572f12f to
c6d95db
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1244 +/- ##
===========================================
+ Coverage 65.89% 65.92% +0.02%
===========================================
Files 86 86
Lines 8887 8894 +7
===========================================
+ Hits 5856 5863 +7
Misses 3031 3031 |
jazi007
force-pushed
the
canutils-io-add-dir-support
branch
from
c6d95db to
e1e722e
Compare
felixdivo
reviewed
Feb 6, 2022
felixdivo
requested changes
Feb 6, 2022
There was a problem hiding this comment.
Apart from the above, this looks good.
For reference: https://github.com/linux-can/can-utils/blob/master/asc2log.c#L185
jazi007
force-pushed
the
canutils-io-add-dir-support
branch
from
e1e722e to
2b0f9d1
Compare
felixdivo
approved these changes
Feb 6, 2022
|
As mentioned in issue #1217: This can be merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1243