fix(ctypesutil): correctly apply wrapped lib function as CLibrary member #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1116 +/- ##
===========================================
- Coverage 70.49% 70.48% -0.01%
===========================================
Files 79 79
Lines 7666 7667 +1
===========================================
Hits 5404 5404
- Misses 2262 2263 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the IXXAT driver we observed that the errcheck function
can.interfaces.ixxat.canlib.__check_statusis never called after library function calls, preventing the detection of timeouts etc. by the caller. The root cause is that the original library function instead of the wrapped function is called.