Skip to content

Avoid flooding the logger with ~500 errors when they are the same #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

pierreluctg
Copy link
Collaborator

Only log/warn each unique error once with repeat count, when needed.
Adding dot to separate end the short description sentence before the long description.

Only log/warn each unique error once with repeat count, when needed.
Adding dot to separate end the short description sentence before the long description.
@mergify mergify bot requested a review from hardbyte September 9, 2021 18:40
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1125 (4bc356f) into develop (9f7077c) will decrease coverage by 0.01%.
The diff coverage is 30.00%.

@@             Coverage Diff             @@
##           develop    #1125      +/-   ##
===========================================
- Coverage    70.50%   70.48%   -0.02%     
===========================================
  Files           79       79              
  Lines         7675     7677       +2     
===========================================
  Hits          5411     5411              
- Misses        2264     2266       +2     

Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handy feature

@hardbyte hardbyte merged commit 596f07d into develop Sep 10, 2021
@hardbyte hardbyte deleted the neovi-unique-error branch September 10, 2021 02:30
@pierreluctg pierreluctg added this to the 4.0.0 Release milestone Sep 10, 2021
pierreluctg added a commit that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants