-
Notifications
You must be signed in to change notification settings - Fork 633
Adding support for gzipped ASC logging file (.asc.gz) #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1138 +/- ##
===========================================
+ Coverage 70.88% 71.01% +0.13%
===========================================
Files 79 79
Lines 7768 7790 +22
===========================================
+ Hits 5506 5532 +26
+ Misses 2262 2258 -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't Python make that easy!
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An example (in a test case) would be nice, but still a good feature! 👍
Maybe one could also add a very minimalistic test similar to this. Whoops, there is also a copy-paste error in that line, I will fix that. |
Thank you for the typo fix. I am working in a full set of unit tests and few other changes since the current code do not really work with This is why I kept the This PR is not technically broken without the logger and player changes. But I would like to make it more complete. |
Sounds great @pierreluctg! |
Co-authored-by: Christian Sandberg <[email protected]>
Eventually it would be nice if we could support other "compressor" (zip, bz2, lzma, tar, etc.) automatically by extension detections. I will leave this to future improvements.