Skip to content

Specific Exceptions: Adapting slcan interface #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2021

Conversation

felixdivo
Copy link
Collaborator

Part of #1046.

Waits for error_check from #1153.

@felixdivo felixdivo added this to the 4.0.0 Release milestone Oct 27, 2021
@felixdivo felixdivo self-assigned this Oct 27, 2021
@mergify mergify bot requested a review from hardbyte October 27, 2021 17:08
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1156 (4ccf5ea) into develop (beb5727) will decrease coverage by 0.02%.
The diff coverage is 37.50%.

@@             Coverage Diff             @@
##           develop    #1156      +/-   ##
===========================================
- Coverage    70.48%   70.45%   -0.03%     
===========================================
  Files           79       79              
  Lines         7684     7690       +6     
===========================================
+ Hits          5416     5418       +2     
- Misses        2268     2272       +4     

@felixdivo felixdivo merged commit ec00893 into develop Nov 11, 2021
@felixdivo felixdivo deleted the felixdivo-issue-1046-slcan branch November 11, 2021 09:24
@felixdivo
Copy link
Collaborator Author

This is completed in #1166

felixdivo added a commit that referenced this pull request Nov 16, 2021
…ce) (#1166)

* Complete switch to new exceptions

* Format code

* Fix TestBaseRotatingLogger
cowo78 pushed a commit to cowo78/python-can that referenced this pull request Dec 9, 2021
… interface) (hardbyte#1166)

* Complete switch to new exceptions

* Format code

* Fix TestBaseRotatingLogger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants