Update workflow versions, platforms, library and tool versions + README #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ADME to Python 3.7
felixdivo
added
the
QA
Codecov Report
@@ Coverage Diff @@
## develop #1214 +/- ##
===========================================
- Coverage 65.75% 65.70% -0.05%
===========================================
Files 86 86
Lines 8859 8859
===========================================
- Hits 5825 5821 -4
- Misses 3034 3038 +4 |
felixdivo
commented
Jan 15, 2022
| @@ -73,7 +72,7 @@ | |||
| version=version, | |||
| packages=find_packages(exclude=["test*", "doc", "scripts", "examples"]), | |||
| scripts=list(filter(isfile, (join("scripts/", f) for f in listdir("scripts/")))), | |||
| author="Python CAN contributors", | |||
| author="python-can contributors", | |||
There was a problem hiding this comment.
I renamed this since it's more familiar for most, I suppose?
hardbyte
approved these changes
Jan 15, 2022
|
@zariiii9003 Do you approve? |
zariiii9003
approved these changes
Jan 15, 2022
There was a problem hiding this comment.
@zariiii9003 Do you approve?
Yeah i was just a little hesitant to drop 3.6 already.
I think there is no point in maintaining an EOL version. People can still install it at their own risk. In the worst case, they have to stick to a certain commit. 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think most changes do not require explanation. The README was changed since Python 3.6 reached EOL as discussed in (the end of the discussion of) #528.