Skip to content

Improve IO typing #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2022
Merged

Improve IO typing #1238

merged 1 commit into from
Jan 27, 2022

Conversation

zariiii9003
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 27, 2022 •
edited
Loading

Codecov Report

Merging #1238 (55c5fdf) into develop (00e2302) will increase coverage by 0.04%.
The diff coverage is 97.93%.

@@             Coverage Diff             @@
##           develop    #1238      +/-   ##
===========================================
+ Coverage    65.84%   65.88%   +0.04%     
===========================================
  Files           86       86              
  Lines         8877     8885       +8     
===========================================
+ Hits          5845     5854       +9     
+ Misses        3032     3031       -1

@felixdivo felixdivo mentioned this pull request Jan 27, 2022
Merged
felixdivo
felixdivo approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this as-is and fix the pylint issues in a subsequent PR to keep the diffs simple and clear.

@zariiii9003 zariiii9003 merged commit 28513eb into hardbyte:develop Jan 27, 2022
@zariiii9003 zariiii9003 deleted the io_typing branch January 27, 2022 13:40
@felixdivo
Copy link
Collaborator

Nice! We're getting there ...

@felixdivo felixdivo added the QA about improving and maintaining the quality of the library label Jan 27, 2022
@felixdivo felixdivo added this to the 4.0.0 Release milestone Jan 27, 2022
@felixdivo felixdivo mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixdivo felixdivo felixdivo approved these changes

Assignees
No one assigned
Labels
QA about improving and maintaining the quality of the library
Projects
None yet
Milestone
4.0.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@zariiii9003 @felixdivo