Skip to content

fix: conversion for port number #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 12, 2022
Merged

Conversation

Thepowa753
Copy link
Contributor

If reading the port number (for remote can) from a config file, the dict contains a string, that crashes becouse it require an integer.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #1309 (746524f) into develop (ed124c9) will decrease coverage by 0.06%.
The diff coverage is 90.00%.

@@             Coverage Diff             @@
##           develop    #1309      +/-   ##
===========================================
- Coverage    66.24%   66.18%   -0.07%     
===========================================
  Files           86       86              
  Lines         9009     9019      +10     
===========================================
+ Hits          5968     5969       +1     
- Misses        3041     3050       +9     

@Thepowa753
Copy link
Contributor Author

I would need some help in figuring out how to fix mypy error No overload variant of "int" matches argument type "object".
I had to add the forcing to int() in 0 < int () < 25565 because otherwise it couldn't find the < operand between int and object. (I think it's because it doesn't take into account the checks made before.)

@Thepowa753 Thepowa753 requested a review from hardbyte June 22, 2022 07:18
@zariiii9003 zariiii9003 merged commit f6d8fe0 into hardbyte:develop Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants