Fix fileno error on Windows (robotell bus) #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1313 +/- ##
===========================================
- Coverage 66.00% 65.98% -0.03%
===========================================
Files 86 86
Lines 8945 8948 +3
===========================================
Hits 5904 5904
- Misses 3041 3044 +3 |
|
Can you add a test that ensures a NotImplementedError on Windows but not on Linux? |
|
I added a function that test the fileno method, but in the tests will always raise a NotImplementedError in both Windows and Linux because it is opening the serial port as 'loop://', which simulates a loopback connection, so I think it is not necessary to discriminate the OS The bad thing is that I don't know how to test if the function returns a valid fileno |
zariiii9003
approved these changes
May 25, 2022
|
Thank you 👍 |
MattWoodhead
added a commit
to MattWoodhead/python-can
that referenced
this pull request
Jun 19, 2022
Change implemented similar to that made in hardbyte#1313. This means notifiers will now work with the Serial interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling io.UnsupportedOperation and raising NotImplementedError prevents #1312 bug