Skip to content

Raise appropriate error message when append is not possible #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 8, 2022
Merged

Raise appropriate error message when append is not possible #1361

merged 11 commits into from
Aug 8, 2022

Conversation

j-c-cook
Copy link
Contributor

@j-c-cook j-c-cook commented Aug 6, 2022

  • Handle "append" by adding **options to SqlWriter
  • Check logger instance for SqliteWriter in rotating logger setup and raise appropriate error.

closes #1318

@j-c-cook
Raise appropriate error messages when SqliteWriter is requested to roll
65f3b74 
- Handle "append" by adding **options to SqlWriter
- Check logger instance for SqliteWriter in rotating logger setup
  and raise appropriate error.
@j-c-cook j-c-cook changed the title Raise appropriate error messages when SqliteWriter is requested to roll Raise appropriate error message when SqliteWriter is requested to roll Aug 6, 2022
@codecov
Copy link

codecov bot commented Aug 6, 2022 •
edited
Loading

Codecov Report

Merging #1361 (59b4b91) into develop (b9d9d01) will increase coverage by 0.07%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop    #1361      +/-   ##
===========================================
+ Coverage    66.06%   66.13%   +0.07%     
===========================================
  Files           86       86              
  Lines         8973     8998      +25     
===========================================
+ Hits          5928     5951      +23     
- Misses        3045     3047       +2

@j-c-cook
Copy link
Contributor Author

j-c-cook commented Aug 6, 2022

@zariiii9003 ready for review.

@j-c-cook j-c-cook marked this pull request as ready for review August 6, 2022 16:44
zariiii9003
zariiii9003 requested changes Aug 6, 2022
View reviewed changes
@j-c-cook
Copy link
Contributor Author

j-c-cook commented Aug 6, 2022

@zariiii9003 Thank you for that feedback. I added in the "append" error handling to ASCWriter and SQLWriter and adjusted the exception based on your comment.

j-c-cook
j-c-cook commented Aug 6, 2022
View reviewed changes
@j-c-cook j-c-cook requested a review from zariiii9003 August 6, 2022 19:19
@j-c-cook j-c-cook mentioned this pull request Aug 6, 2022
Merged
zariiii9003
zariiii9003 reviewed Aug 6, 2022
View reviewed changes
zariiii9003
zariiii9003 reviewed Aug 6, 2022
View reviewed changes
j-c-cook
j-c-cook commented Aug 6, 2022
View reviewed changes
j-c-cook
j-c-cook commented Aug 6, 2022
View reviewed changes
@j-c-cook j-c-cook requested a review from zariiii9003 August 6, 2022 22:45
@j-c-cook
Copy link
Contributor Author

j-c-cook commented Aug 7, 2022

@zariiii9003 I think this might be ready to go in. Could you give it another look?

zariiii9003
zariiii9003 approved these changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good

@zariiii9003 zariiii9003 changed the title Raise appropriate error message when SqliteWriter is requested to roll Raise appropriate error message when append is not possible Aug 8, 2022
@zariiii9003 zariiii9003 merged commit 73663b6 into hardbyte:develop Aug 8, 2022
@j-c-cook j-c-cook deleted the issue1318_Sqlite_rotating_error_msg branch August 11, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zariiii9003 zariiii9003 zariiii9003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance the error message when requesting file format .db with sized rotating logger
2 participants
@j-c-cook @zariiii9003