Fix #1376 #1412
Merged
Fix #1376 #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1412 +/- ##
========================================
Coverage 65.27% 65.27%
========================================
Files 81 81
Lines 8777 8777
========================================
Hits 5729 5729
Misses 3048 3048 |
|
ping @umlaeute |
|
I can confirm that this PR fixes the unfortunately the testsuite still fails on s390x, but this time with from my side, the fix looks good. |
|
Thank you for the feedback. I'll create another PR for that, too. |
j-c-cook
added a commit
to j-c-cook/python-can
that referenced
this pull request
Nov 11, 2022
This reverts commit a344a13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1376
@umlaeute Could you run your tests with this branch?