Skip to content

Remove deprecated features #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 19, 2019
Merged

Remove deprecated features #595

merged 10 commits into from
May 19, 2019

Conversation

felixdivo
Copy link
Collaborator

@felixdivo felixdivo commented May 18, 2019

This removes a lot of deprecated features, which were scheduled for removal in 4.0.

Fixes: #502

@felixdivo felixdivo added this to the 4.0 Release milestone May 18, 2019
@felixdivo felixdivo self-assigned this May 18, 2019
@codecov
Copy link

codecov bot commented May 18, 2019

Codecov Report

Merging #595 into develop will decrease coverage by 56.08%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #595       +/-   ##
===========================================
- Coverage    64.17%   8.09%   -56.09%     
===========================================
  Files           63      63               
  Lines         5722    5685       -37     
===========================================
- Hits          3672     460     -3212     
- Misses        2050    5225     +3175

@codecov
Copy link

codecov bot commented May 18, 2019

Codecov Report

Merging #595 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #595      +/-   ##
===========================================
+ Coverage    64.17%   64.23%   +0.06%     
===========================================
  Files           63       63              
  Lines         5722     5685      -37     
===========================================
- Hits          3672     3652      -20     
+ Misses        2050     2033      -17

@felixdivo
Copy link
Collaborator Author

I hope I removed all documentation that is now obsolete. That should be checked in a PR review.

@felixdivo felixdivo merged commit 978d010 into develop May 19, 2019
@hardbyte
Copy link
Owner

💪 strong ratio

@hardbyte hardbyte deleted the remove-deprecated-features branch May 19, 2019 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated members of Message class
3 participants