Fix crash in Canutils Log Reader when parsing RTR frames #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding remote frames
Codecov Report
@@ Coverage Diff @@
## develop #713 +/- ##
===========================================
+ Coverage 68.37% 68.38% +<.01%
===========================================
Files 69 69
Lines 6201 6202 +1
===========================================
+ Hits 4240 4241 +1
Misses 1961 1961 |
|
Thanks for the fix! I guess this is indicative of how many people use RTR frames, since it's been present for over a year 😂 @hardbyte we probably will want to backport this to a |
karlding
changed the title
…ding_remote_frames
|
Yeah it would be good to backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable dataBin in CanutilsLogReader was not defined before it was accessed when reading remote frames.