Fixing ASCII reader unable to read FD frames #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #741 +/- ##
========================================
Coverage 69.69% 69.69%
========================================
Files 70 70
Lines 6498 6498
========================================
Hits 4529 4529
Misses 1969 1969 |
pierreluctg
reviewed
Dec 9, 2019
|
@pierreluctg Resolved all comments |
pierreluctg
approved these changes
Dec 10, 2019
|
@hardbyte can you please review. Thank you |
|
@pierreluctg can this be merged? I think it looks good. |
|
@felixdivo looks good to me. |
This was referenced Apr 22, 2020
Merged
hardbyte
pushed a commit
that referenced
this pull request
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAN FD Frames in an ASCII log file could be logged in the following format:
These frames are currently not read and skipped when using can.LogReader. This PR enables those frames to be read and processed.
Added unit tests for the same.