Add _detect_available_configs to serial_can #811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I am using serial_can interface and I was missing the serial port detection.
This is very simple PR, it just adds pySerial
list_ports.comports()
call non-intrusive way.I.e. if the detection fails (or
serial.tools.list_ports
is not available) for one reason or another it just gives an empty list.It does not attempt to get more detailed configuration (e.g. baudrates) besides the list of serial ports.
Tested on Linux and Windows:
Linux:
Window:
As you'd expect. These configs can be directly used to connect to the interface (with the default baudrate of the serial interface).