-
Notifications
You must be signed in to change notification settings - Fork 631
Version bump CI tools #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The automated static analysis tools are updated to their most recent version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎖️
How useful is it to have both Github actions as well as AppVeyor an Travis CI? Wouldn't it be nice to at least remove the tests from Travis CI as they seem to be very slow and a duplicate. Also, do we need AppVeyor at all? EDIT: Proposal:
|
Travis-CI might be a bit faster now I just migrated to the travis-ci.com version. But yes I think just relying on github workflow except where we need additional functionality is the way forward. Is there more you want to do in this PR? |
I basically updated the tools in |
Seems like this uncovered an actual problem: https://github.com/hardbyte/python-can/pull/940/checks?check_run_id=1458088551#step:4:101. Pypy support for that lib is aparrently not available, see python/typed_ast#111. |
Codecov Report
@@ Coverage Diff @@
## develop #940 +/- ##
===========================================
- Coverage 70.28% 69.53% -0.76%
===========================================
Files 76 76
Lines 7398 7455 +57
===========================================
- Hits 5200 5184 -16
- Misses 2198 2271 +73 |
I also opened EDIT: was redirected to pypa/wheel#382 |
The problem on Python version 3.10 with |
Seems like this time, we actually uncovered a bug in our repository: https://github.com/hardbyte/python-can/pull/940/checks?check_run_id=1753568353#step:5:333 |
We could set python 3.10 to experimental and merge this. What do you think? |
Here's a new one (for me): https://github.com/hardbyte/python-can/pull/940/checks?check_run_id=2336410553#step:5:332 And the pypy3 threading error also occurs on windows. |
Should be fixed. The runners have such an unreliable timing that any kind of deadline/timing assert seems to fail eventually. |
Asyncio error in python 3.10 is tracked in #1005 |
…/python-can into felixdivo-patch-update-ci-tools
@zariiii9003 Everything seems to be done now, right? |
Depends, do we keep Appveyor? |
It would also touch a few (even more) lines, I'd just do it in a separate PR right after this one is merged. It's already somewhat too large I think. |
@hardbyte Do you wish to do/have someone do another review or is it OK to be merged as is? |
Good work hunting down all the loose ends! Happy to merge |
@zariiii9003 Nice work, thanks for joining. I'll assemble a much simpler PR that will remove AppVeyor in a minute. |
The automated static analysis tools are updated to their most recent version.
EDIT: I basically updated the tools in
requirements-lint.txt
and some images in Travis CI. Then I and re-ran the formatter, which causes much of the diff. I also removed the formatting job from Travis as it was already done by Github actions. I removed the normal testing from Travis, as it is much easier to specify in Github actions (and we now also test more platforms, like properly test on macOS!). We now also test on newer versions of Python as well (currently up to3.10.0-alpha.4
) and on Pypy on all platforms (also new).