Skip to content

Extract constant for start of file date format in ASCWriter #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

tojoh511
Copy link
Contributor

@tojoh511 tojoh511 commented Dec 2, 2020

Change-Id: I09ff06907f0a8ee8dd2d0a4a1cd480a7faf4dd4c

Change-Id: I09ff06907f0a8ee8dd2d0a4a1cd480a7faf4dd4c
@mergify mergify bot requested a review from hardbyte December 2, 2020 09:25
@tojoh511
Copy link
Contributor Author

tojoh511 commented Dec 2, 2020

CANalyzer can't handle decimals in header timestamps. Extract "constant" for start of file date format to be able to change the header.

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #955 (8441cb8) into develop (974d8a8) will decrease coverage by 3.86%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #955      +/-   ##
===========================================
- Coverage    70.47%   66.61%   -3.87%     
===========================================
  Files           72       72              
  Lines         7123     7009     -114     
===========================================
- Hits          5020     4669     -351     
- Misses        2103     2340     +237     

Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too easy. Thanks for the contribution!

@hardbyte hardbyte merged commit b0273d9 into hardbyte:develop Dec 2, 2020
@hardbyte hardbyte added file-io about reading & writing to files minor labels Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-io about reading & writing to files minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants