-
Notifications
You must be signed in to change notification settings - Fork 630
Add Neousys WDT_DIO CAN interface #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #980 +/- ##
===========================================
+ Coverage 70.12% 70.74% +0.61%
===========================================
Files 76 78 +2
Lines 7381 7551 +170
===========================================
+ Hits 5176 5342 +166
- Misses 2205 2209 +4 |
bdcc093
to
d5c8010
Compare
c370ad3
to
0ecb11e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look pretty good. A few minor comments inline.
Please add an interface documentation page before we merge
@hardbyte I reorgazied to Queue and it's in own subdir. I have to test this more to be sure it works as expected. Need also make sure that there is no need to catch Queue.Empty and Full (they should be tested but documentation is little bit shy about this) |
Thanks @illuusio - please let me know when you'd like another review. |
…Bus to NeousysBus
@hardbyte now it should be up to another review as it has unit test also (no marvelous but should catch most of the stuff). Strange I reformatted test_neosys.py with black but it's still failing I have to correct that. |
Co-authored-by: Felix Divo <[email protected]>
Co-authored-by: Felix Divo <[email protected]>
Bindings to Neousys DLL/SO so one can use CAN interface