Skip to content

Add Neousys WDT_DIO CAN interface #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 17, 2021
Merged

Conversation

illuusio
Copy link
Contributor

Bindings to Neousys DLL/SO so one can use CAN interface

@mergify mergify bot requested a review from hardbyte February 18, 2021 09:24
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #980 (4a41db7) into develop (291af86) will increase coverage by 0.61%.
The diff coverage is 87.12%.

@@             Coverage Diff             @@
##           develop     #980      +/-   ##
===========================================
+ Coverage    70.12%   70.74%   +0.61%     
===========================================
  Files           76       78       +2     
  Lines         7381     7551     +170     
===========================================
+ Hits          5176     5342     +166     
- Misses        2205     2209       +4     

@illuusio illuusio force-pushed the neousys_wdt branch 3 times, most recently from c370ad3 to 0ecb11e Compare February 18, 2021 11:21
Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look pretty good. A few minor comments inline.

Please add an interface documentation page before we merge

@illuusio
Copy link
Contributor Author

@hardbyte I reorgazied to Queue and it's in own subdir. I have to test this more to be sure it works as expected. Need also make sure that there is no need to catch Queue.Empty and Full (they should be tested but documentation is little bit shy about this)

@hardbyte
Copy link
Owner

hardbyte commented Apr 4, 2021

Thanks @illuusio - please let me know when you'd like another review.

@illuusio
Copy link
Contributor Author

illuusio commented Apr 6, 2021

@hardbyte now it should be up to another review as it has unit test also (no marvelous but should catch most of the stuff). Strange I reformatted test_neosys.py with black but it's still failing I have to correct that.

@felixdivo felixdivo requested a review from hardbyte April 14, 2021 13:10
@felixdivo felixdivo added this to the 4.0.0 Release milestone Apr 16, 2021
@felixdivo felixdivo merged commit 84e1f36 into hardbyte:develop Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants