Skip to content

add set/get pcan device number #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2021
Merged

add set/get pcan device number #987

merged 1 commit into from
Mar 16, 2021

Conversation

gordon-epc
Copy link
Contributor

Add get_pcan_device_number and set_pcan_device_number methods, which gives the ability to get/set PCAN device number/ID like the PEAK-System PCAN-View application.

@mergify mergify bot requested a review from hardbyte March 12, 2021 01:05
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #987 (f451343) into develop (68bee14) will decrease coverage by 0.09%.
The diff coverage is 15.38%.

@@             Coverage Diff             @@
##           develop     #987      +/-   ##
===========================================
- Coverage    70.39%   70.30%   -0.10%     
===========================================
  Files           76       76              
  Lines         7381     7394      +13     
===========================================
+ Hits          5196     5198       +2     
- Misses        2185     2196      +11     

@gordon-epc
Copy link
Contributor Author

I tested the new methods by connecting a PEAK-System PCAN-USB interface (IPEH-002021) to a Windows PC, executing the PCAN-View application, calling the set method and verifying that PCAN-View updated accordingly, and calling get and checking that it returned the expected value. I also tested the set method with a variety of good and bad parameter values and the method behaved appropriately.

@gordon-epc gordon-epc marked this pull request as ready for review March 13, 2021 02:06
@hardbyte hardbyte added this to the 4.0 Release milestone Mar 14, 2021
@hardbyte
Copy link
Owner

Thanks for the contribution, could you please take a look at the failing tests - https://travis-ci.com/github/hardbyte/python-can/jobs/490305673

@KloolK
Copy link

KloolK commented Mar 15, 2021

Confirmed to also work with PCAN-USB FD (IPEH-004022) 👍

@gordon-epc
Copy link
Contributor Author

It looks like the failing test also failed the same way on the current head of develop.

@hardbyte
Copy link
Owner

Ahh that's not great. Thanks for following up.

@hardbyte hardbyte merged commit 2ede107 into hardbyte:develop Mar 16, 2021
@gordon-epc gordon-epc deleted the feature/get_set_pcan_device_id branch March 16, 2021 01:55
@altendky
Copy link
Contributor

It is still failing, but there's an attempt to fix the issue over in #984.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants