-
Notifications
You must be signed in to change notification settings - Fork 631
add set/get pcan device number #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add set/get pcan device number #987
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #987 +/- ##
===========================================
- Coverage 70.39% 70.30% -0.10%
===========================================
Files 76 76
Lines 7381 7394 +13
===========================================
+ Hits 5196 5198 +2
- Misses 2185 2196 +11 |
I tested the new methods by connecting a PEAK-System PCAN-USB interface (IPEH-002021) to a Windows PC, executing the PCAN-View application, calling the set method and verifying that PCAN-View updated accordingly, and calling get and checking that it returned the expected value. I also tested the set method with a variety of good and bad parameter values and the method behaved appropriately. |
Thanks for the contribution, could you please take a look at the failing tests - https://travis-ci.com/github/hardbyte/python-can/jobs/490305673 |
Confirmed to also work with PCAN-USB FD (IPEH-004022) 👍 |
It looks like the failing test also failed the same way on the current head of develop. |
Ahh that's not great. Thanks for following up. |
It is still failing, but there's an attempt to fix the issue over in #984. |
Add get_pcan_device_number and set_pcan_device_number methods, which gives the ability to get/set PCAN device number/ID like the PEAK-System PCAN-View application.