Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form validation improvement 2 #1253

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ankormoreankor
Copy link
Collaborator

@ankormoreankor ankormoreankor commented Mar 14, 2025

Part 2 of forms validation improvement

  • Added more validation cases on the client side to show better validation error to a user and improve UX
  • Added more translations, including the validation messages
  • More properly organized form fields into field sets where necessary, preferably
  • The Option component can now render an error message the same way as other form fields
  • The Fieldset component can now render the legend element visible only to assistive devices. The legend element is essential for the fieldset element
  • Reduced unnecessary wrappers in forms

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for harness-design ready!

Name Link
🔨 Latest commit 668fa53
🔍 Latest deploy log https://app.netlify.com/sites/harness-design/deploys/67ee74946b997d0008acd77f
😎 Deploy Preview https://deploy-preview-1253--harness-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit 668fa53
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/67ee74943b87a70008d5318d
😎 Deploy Preview https://deploy-preview-1253--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ankormoreankor ankormoreankor force-pushed the form-validation-improvement-2 branch 13 times, most recently from 9b0c06e to 40c3720 Compare March 19, 2025 09:58
@ankormoreankor ankormoreankor force-pushed the form-validation-improvement-2 branch from 40c3720 to a7ee799 Compare March 26, 2025 13:10
@ankormoreankor ankormoreankor force-pushed the form-validation-improvement-2 branch 2 times, most recently from 84b80cd to d9f390e Compare April 3, 2025 11:43
@ankormoreankor ankormoreankor force-pushed the form-validation-improvement-2 branch from d9f390e to 668fa53 Compare April 3, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants