Skip to content

FFM-11360 Use target-segments v2-rule parameter / Swap to atomic wrapper in analytics #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 2, 2024

Conversation

erdirowlands
Copy link
Contributor

What

  • Re-generates the API client to bring in the new target-segments query parameter rules
  • Sets this parameter on all requests to target-segments and target-segments/{segment}

Testing

Manual inspection of final URL string when

  • Pulling all segments
    Screenshot 2024-05-01 at 19 50 27

  • Pulling a specific segment when a group change has been streamed
    Screenshot 2024-05-01 at 20 59 21

FFM-11360 Add request params

FFM-11360 Attempt at not hardcoding params
@erdirowlands erdirowlands changed the title FFM-11360 Use target-segments v2-rule parameter FFM-11360 Use target-segments v2-rule parameter / Swap to atomic wrapper in analytics May 2, 2024
@erdirowlands erdirowlands merged commit d2fb709 into main May 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants