fix: [FFM-4743]: Prevent connection after close has been called #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Bug FFM-4743 · Exception caused by JS SDK connection issue |
crystal-fong
approved these changes
Oct 17, 2022
stephenmcconkey
approved these changes
Oct 17, 2022
laura-mannus
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue whereby calling the
closemethod before the stream was opened could cause the SDK to throw an error aseventstreamwas undefined. With this PR, both a check to ensureeventstream.closeis a function before calling it, and checks to make sure theclosemethod wasn't called before opening connections, were added.