Merge pull request #25 from drone/FFM-1507

[FFM-1507] metrics event target fixed, minor changes

Author: enver-bisevac

example/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@harnessio/ff-nodejs-server-sdk",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Feature flags SDK for NodeJS environments",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",

package.json

@@ -157,7 +157,7 @@ export const MetricsProcessor = (
         },
         {
           key: TARGET_ATTRIBUTE,
-          value: event.target.identifier,
+          value: event?.target?.identifier ?? null,
         },
       ];
 

src/metrics.ts

@@ -1,4 +1,3 @@
-import { AxiosResponse } from 'axios';
 import { ClientApi, FeatureConfig, Segment } from './openapi';
 import { Options } from './types';
 import EventEmitter from 'events';
@@ -65,9 +64,7 @@ export class PollingProcessor {
       .finally(pollAgain);
   }
 
-  private async retrieveFlags(): Promise<void | AxiosResponse<
-    FeatureConfig[]
-  >> {
+  private async retrieveFlags(): Promise<void> {
     try {
       log.debug('Fetching flags started');
       const response = await this.api.getFeatureConfig(this.environment, {
@@ -85,7 +82,7 @@ export class PollingProcessor {
     }
   }
 
-  private async retrieveSegments(): Promise<void | AxiosResponse<Segment[]>> {
+  private async retrieveSegments(): Promise<void> {
     try {
       log.debug('Fetching segments started');
       const response = await this.api.getAllSegments(this.environment, {

src/polling.ts

@@ -56,8 +56,8 @@ export interface Operator {
 }
 
 export interface Query {
-  getFlag(identifier: string): Promise<FeatureConfig>;
-  getSegment(identifier: string): Promise<Segment>;
+  getFlag(identifier: string, cacheable?: boolean): Promise<FeatureConfig>;
+  getSegment(identifier: string, cacheable?: boolean): Promise<Segment>;
 }
 
 export interface KeyValueStore {

src/types.ts

@@ -1 +1 @@
-export const VERSION = "1.1.0";
+export const VERSION = "1.1.1";