Skip to content

[FFM-1507] metrics event target fixed, minor changes #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2021
Merged

[FFM-1507] metrics event target fixed, minor changes #25

merged 1 commit into from
Oct 19, 2021

Conversation

enver-bisevac
Copy link
Contributor

  • When metric event target is undefined in ESM module throws an exception
  • Minor changes in Query interface signature

@enver-bisevac enver-bisevac requested review from knagurski and a user October 18, 2021 11:25
knagurski
knagurski approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@knagurski knagurski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@enver-bisevac enver-bisevac merged commit a618c69 into main Oct 19, 2021
@enver-bisevac enver-bisevac deleted the FFM-1507 branch October 19, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knagurski knagurski knagurski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enver-bisevac @knagurski