FFM-10325 Fix issue with detecting empty evaluation/target metrics #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or SSE heartbeats
erdirowlands
commented
Jan 3, 2024
| @@ -101,11 +101,6 @@ export const MetricsProcessor = ( | |||
| }; | |||
|
|
|||
| const _summarize = (): Metrics | unknown => { | |||
| if (!data) { | |||
There was a problem hiding this comment.
data is initialized when it is declared so this will always be true
erdirowlands
commented
Jan 3, 2024
| return; | ||
| } | ||
|
|
||
| const metrics: Metrics = _summarize(); | ||
|
|
||
| if (metrics && metrics.metricsData.length && metrics.targetData.length) { |
There was a problem hiding this comment.
We can safely remove this check, because the earlier data check now works correctly.
andybharness
approved these changes
Jan 3, 2024
erdirowlands
force-pushed
the
FFM-10325
branch
from
23a8ae2 to
12603f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Tidies up logic around checking if there are valid metrics to process. This also ensures that metrics are processed and sent when a target hasn't been used for an evaluation.
Also fixes an issue where we log
5002on SSE heartbeat eventsWhy
A customer reported that when evaluating without a target, their flag metrics were not being reported.
Testing
TestGrid metrics suite
Manual sample script:
undefinedtargetSSE Testing: