FFM-10409 Mark targets as optional for variation methods #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We allow targets to to undefined when calling variation methods, but if
"strictNullChecks": true
is enabled in a Typescript project, then passing an undefined target will result in a compilation fail.This marks the
target
as explicitly optional for all variation methods.Testing
Manual:
strictNullChecks
and passed undefined targets and real targets with targeting rules enabled on each flag type.strictNullChecks
for undefined and real targets with targeting rules enabled on each flag type.