TypeScript: don't use outfile with tsc - it does not support modules #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing
@harnessio/ff-nodejs-server-sdk
and importing it in a typescript project results in a typescript error[1]. The is caused by this package being built withtsc --outfile
which is not supposed to be used with module files and should only be used for libraries which expose global variables.To reproduce the error, check out kdojeteri/harness-ff-typescript-error.
This pull request removes the
--outfile ./dist/index.d.ts
parameter and replaces it with--outdir ./dist
, which fixes the error.[1]