Skip to content

[FFM-1263] flag rules evaluations, repository with persistent #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2021

Conversation

enver-bisevac
Copy link
Contributor

Repository patternt with cache support
Flag rules evaluations

Copy link

@davejohnston davejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me (though I'm not experienced in Node). The repository pattern and evaluator seem like a good approach here.

Copy link

@chrisblakely01 chrisblakely01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Do you think we should put some unit tests in?

@enver-bisevac
Copy link
Contributor Author

Looks pretty good! Do you think we should put some unit tests in?

Yes, after we all agree this is the way we should go. Evaluator should be 100% covered, that is for us most important part.

@chrisblakely01
Copy link

Looks pretty good! Do you think we should put some unit tests in?

Yes, after we all agree this is the way we should go. Evaluator should be 100% covered, that is for us most important part.

Cool, sounds good to me

@chrisblakely01 chrisblakely01 self-requested a review September 14, 2021 11:08
@enver-bisevac enver-bisevac merged commit 4f20882 into main Sep 15, 2021
@enver-bisevac enver-bisevac deleted the FFM-1263 branch September 15, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants