[FFM-1264] segment evaluator #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knagurski
reviewed
Sep 15, 2021
knagurski
reviewed
Sep 15, 2021
knagurski
reviewed
Sep 15, 2021
knagurski
reviewed
Sep 15, 2021
knagurski
reviewed
Sep 15, 2021
knagurski
reviewed
Sep 15, 2021
knagurski
reviewed
Sep 15, 2021
knagurski
reviewed
Sep 15, 2021
src/evaluator.ts
Outdated
|
|
||
| // not found in rules proceed with default serve | ||
| variation = fc.defaultServe.variation; | ||
| // default serve variation is undefined so continue with distribution |
There was a problem hiding this comment.
It doesn't appear that you are testing whether the default serve variation is undefined
knagurski
reviewed
Sep 15, 2021
| @@ -95,11 +95,35 @@ export class CfClient { | |||
| boolVariation( | |||
| identifier: string, | |||
| target: Target, | |||
| defaultValue: false, | |||
| defaultValue = false, | |||
There was a problem hiding this comment.
Good catch. I make this error ALL the time in TS
knagurski
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.