FFM-4204 Fallback to polling if stream has an error #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdirowlands
force-pushed
the
FFM-4204
branch
from
4cee79d to
47ba0f0
Compare
erdirowlands
commented
Feb 24, 2023
package.json
Outdated
| @@ -64,7 +63,7 @@ | |||
| "dependencies": { | |||
| "axios": "^0.22.0", | |||
| "axios-retry": "^3.2.0", | |||
| "eventsource": "^1.1.2", | |||
| "@harness/event": "file:../eventsource", | |||
There was a problem hiding this comment.
This will be updated once the package is published to NPM. Feel free to mark the PR as requested changes until this is done, along with any other required changes.
andybharness
approved these changes
Feb 24, 2023
erdirowlands
force-pushed
the
FFM-4204
branch
from
7386e10 to
4be9b53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Previously, the SDK would not fall back to polling if there was an error in the stream. This was caused by a number of issues
StreamEvent.ERROReventseventsourcelibrary had a number of issues and so we have forked it and put our own fixes in there. See PR for details. The SDK uses the new #harness.io/event NPM package which is pending publication to NPM. ** BUILD WILL FAIL UNTIL PACKAGE PUBLISHED **Testing
Manual. Extensive.