[FFM-10041] - Fall back to identifier if bucketBy attr is not found #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What Update BucketBy logic to fall back to the target identifier if given BucketBy attribute is not found. Why Keep the SDK consistent with the behaviour of the other server SDKs. Testing Testgrid + new unit test
erdirowlands
approved these changes
Nov 23, 2023
knagurski
reviewed
Nov 23, 2023
knagurski
reviewed
Nov 23, 2023
knagurski
reviewed
Nov 23, 2023
knagurski
reviewed
Nov 23, 2023
knagurski
reviewed
Nov 23, 2023
knagurski
reviewed
Nov 23, 2023
knagurski
reviewed
Nov 23, 2023
Co-authored-by: Kevin Nagurski <[email protected]>
Co-authored-by: Kevin Nagurski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFM-10041 - Fall back to identifier if bucketBy attribute is not found
What
Update BucketBy logic to fall back to the target identifier if given BucketBy attribute is not found.
Adds new unit test to test fallback logic works.
Why
Keep the SDK consistent with the behaviour of the other server SDKs.
Testing
Testgrid + new unit test