Skip to content

add warning message to vcs troubleshooting page about reauthorizing #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2022
Merged

add warning message to vcs troubleshooting page about reauthorizing #211

merged 4 commits into from
Dec 2, 2022

Conversation

mjyocca
Copy link
Contributor

@mjyocca mjyocca commented Nov 10, 2022 •
edited
Loading

What

Changing VCS troubleshooting page to include warning about Reauthorize incompatibility with OAuth Clients managed by the TFE Provider.

Why

Screenshots

Merge Checklist

If items do not apply to your changes, add (N/A) and mark them as complete.

Pull Request

  • One or more labels describe the type of change (e.g. clarification) and associated product (e.g. tfc).
  • Description links to related pull requests or issues, if any.

Content

  • Redirects have been added for moved, renamed, or deleted pages. This requires a separate PR in the terraform-website repository redirects.next.js file.
  • API documentation and the API Changelog have been updated.
  • Links to related content where appropriate (e.g., API endpoints, permissions, etc.).
  • Pages with related content are updated and link to this content when appropriate.
  • Sidebar navigation files have been updated for added, deleted, reordered, or renamed pages.
  • New pages have metadata (page name and description) at the top.
  • New images are 2048 px wide. They have HashiCorp standard annotation color (#F92672) and format (rectangle with rounded corners), blurred sensitive details (e.g. credentials, usernames, user icons), and descriptive alt text in the markdown for accessibility.
  • New code blocks have the correct syntax and line breaks to eliminate horizontal scroll bars.
  • UI elements (button names, page names, etc.) are bolded.
  • The Vercel website preview successfully deployed.

Reviews

  • I or someone else reviewed the content for technical accuracy.
  • I or someone else reviewed the content for typos, punctuation, spelling, and grammar.

@vercel
Copy link

vercel bot commented Nov 10, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
terraform-docs-common ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 2:59AM (UTC)

@mjyocca mjyocca marked this pull request as ready for review November 11, 2022 17:29
@mjyocca mjyocca requested a review from laurapacilio November 14, 2022 16:54
@mjyocca mjyocca requested a review from laurapacilio November 21, 2022 17:49
laurapacilio
laurapacilio approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one final language nit. Thank you very much!!

@mjyocca mjyocca merged commit 1da767f into main Dec 2, 2022
@mjyocca mjyocca deleted the mjyocca/reauthorize-tfe-provider-update branch December 2, 2022 17:36
BrianMMcClain pushed a commit that referenced this pull request Aug 2, 2024
@hashibot-web
Merge pull request #211 from hashicorp/repo-sync
686e658 
repo sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurapacilio laurapacilio laurapacilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjyocca @laurapacilio