Skip to content

Fix arguments for tfe_outputs data source #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

thaim
Copy link

@thaim thaim commented Jan 7, 2023

What

Fix arguments for tfe_outputs data source in Terraform State in Terraform Cloud page.

Why

Current arguments are for terraform_remote_state data source. These are different from the arguments for tfe_outputs data source.

In addition, the note at the bottom "Remote state access controls do not apply when using the tfe_outputs data source" seems incorrect. As far as I have tried, remote state access controls also apply to the tfe_outputs data source. I'm not sure if this note should be deleted.

Screenshots


Merge Checklist

If items do not apply to your changes, add (N/A) and mark them as complete.

Pull Request

  • One or more labels describe the type of change (e.g. clarification) and associated product (e.g. tfc).
  • Description links to related pull requests or issues, if any.

Content

  • Redirects have been added for moved, renamed, or deleted pages. This requires a separate PR in the terraform-website repository redirects.next.js file.
  • API documentation and the API Changelog have been updated.
  • Links to related content where appropriate (e.g., API endpoints, permissions, etc.).
  • Pages with related content are updated and link to this content when appropriate.
  • Sidebar navigation files have been updated for added, deleted, reordered, or renamed pages.
  • New pages have metadata (page name and description) at the top.
  • New images are 2048 px wide. They have HashiCorp standard annotation color (#F92672) and format (rectangle with rounded corners), blurred sensitive details (e.g. credentials, usernames, user icons), and descriptive alt text in the markdown for accessibility.
  • New code blocks have the correct syntax and line breaks to eliminate horizontal scroll bars.
  • UI elements (button names, page names, etc.) are bolded.
  • The Vercel website preview successfully deployed.

Reviews

  • I or someone else reviewed the content for technical accuracy.
  • I or someone else reviewed the content for typos, punctuation, spelling, and grammar.

@vercel
Copy link

vercel bot commented Jan 7, 2023

@thaim is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 7, 2023

CLA assistant check
All committers have signed the CLA.

@@ -232,16 +232,13 @@ By default, new workspaces in HCP Terraform do not allow other workspaces to acc

To configure a `tfe_outputs` data source that references an HCP Terraform workspace, specify the organization and workspace in the `config` argument.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@rkoron007
Copy link
Contributor

Hello! 👋 I'm combing through our backlog, and I apologize for the very late response here! It looks like someone updated this in another PR, so I'm going to close this one out.

Thank you so much catching this and contributing! ✨

@rkoron007 rkoron007 closed this May 3, 2024
BrianMMcClain pushed a commit that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants