Skip to content

Enable auto-apply for run trigger runs #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 31, 2023
Merged

Enable auto-apply for run trigger runs #377

merged 10 commits into from
Oct 31, 2023

Conversation

Uk1288
Copy link
Contributor

@Uk1288 Uk1288 commented Jun 22, 2023 •
edited
Loading

What

Update docs to indicate support of auto-apply for run triggers

Why

Screenshots

Screenshot 2023-06-22 at 4 35 55 PM
Screenshot 2023-08-02 at 3 34 55 PM

Merge Checklist

If items do not apply to your changes, add (N/A) and mark them as complete.

Pull Request

  • One or more labels describe the type of change (e.g. clarification) and associated product (e.g. tfc).
  • Description links to related pull requests or issues, if any.

Content

  • Redirects have been added for moved, renamed, or deleted pages. This requires a separate PR in the terraform-website repository redirects.next.js file. N/A
  • API documentation and the API Changelog have been updated.
  • Links to related content where appropriate (e.g., API endpoints, permissions, etc.). N/A
  • Pages with related content are updated and link to this content when appropriate. N/A
  • Sidebar navigation files have been updated for added, deleted, reordered, or renamed pages. N/A
  • New pages have metadata (page name and description) at the top. N/A
  • New images are 2048 px wide. They have HashiCorp standard annotation color (#F92672) and format (rectangle with rounded corners), blurred sensitive details (e.g. credentials, usernames, user icons), and descriptive alt text in the markdown for accessibility. N/A
  • New code blocks have the correct syntax and line breaks to eliminate horizontal scroll bars. N/A
  • UI elements (button names, page names, etc.) are bolded. N/A
  • The Vercel website preview successfully deployed.

Reviews

  • I or someone else reviewed the content for technical accuracy.
  • I or someone else reviewed the content for typos, punctuation, spelling, and grammar.

@vercel
Copy link

vercel bot commented Jun 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
terraform-docs-common ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 9:37pm

@Uk1288 Uk1288 changed the title add note to indicate that auto-apply has been enabled for run triggers Enable auto-apply for run trigger runs Aug 2, 2023
@Uk1288 Uk1288 force-pushed the enable-auto-apply-for-run-triggers branch from 0134be0 to 86fc742 Compare August 2, 2023 19:38
@Uk1288 Uk1288 marked this pull request as ready for review August 2, 2023 19:47
uturunku1
uturunku1 previously requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@uturunku1 uturunku1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-08-09 at 3 04 01 PM I was noticing the sentences for the changelog start in present tense. Aside from this change, I am ready to approve this PR!

@Uk1288 Uk1288 force-pushed the enable-auto-apply-for-run-triggers branch from 3820531 to 5bdb795 Compare August 14, 2023 14:22
@Uk1288 Uk1288 force-pushed the enable-auto-apply-for-run-triggers branch from 5bdb795 to 8fd3843 Compare August 21, 2023 19:33
@nfagerlund nfagerlund force-pushed the enable-auto-apply-for-run-triggers branch from 8fd3843 to d522d56 Compare October 28, 2023 00:35
@nfagerlund nfagerlund mentioned this pull request Oct 31, 2023
Merged
2 tasks
@nfagerlund nfagerlund force-pushed the enable-auto-apply-for-run-triggers branch from d522d56 to 35c038f Compare October 31, 2023 18:23
@nfagerlund nfagerlund dismissed uturunku1’s stale review October 31, 2023 20:44

change got made!

rkoron007
rkoron007 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions for style, but this looks great to me! As always, feel free to push back on anything that doesn't feel good to you ✨

@nfagerlund @rkoron007
Apply copyedits from review
e422e5c 
Co-authored-by: Rose M Koron <[email protected]>
@nfagerlund nfagerlund merged commit e0d3de6 into main Oct 31, 2023
@nfagerlund nfagerlund deleted the enable-auto-apply-for-run-triggers branch October 31, 2023 21:33
hashibot-web added a commit that referenced this pull request Apr 4, 2025
@hashibot-web
Merge pull request #377 from hashicorp/repo-sync
f105494 
repo sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonc brandonc brandonc left review comments

@rkoron007 rkoron007 rkoron007 approved these changes

@uturunku1 uturunku1 uturunku1 left review comments

Assignees
No one assigned
Labels
HCP Terraform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Uk1288 @brandonc @uturunku1 @rkoron007 @nfagerlund