The plugin has issue with id field. It marks all id fields as readonly

[komalkadam-dc]

Terraform CLI and terraform-plugin-docs Versions

terraform version Terraform v1.6.6 on darwin_arm64

github.com/hashicorp/terraform-plugin-docs v0.18.0

Provider Code

https://registry.terraform.io/providers/duplocloud/duplocloud/latest/docs/resources/plan_certificates#certificate

Expected Behavior

Marking the fields id as read only even if the are nested
https://registry.terraform.io/providers/duplocloud/duplocloud/latest/docs/resources/plan_certificates#id

Actual Behavior

https://registry.terraform.io/providers/duplocloud/duplocloud/latest/docs/resources/plan_certificates#id

Steps to Reproduce

1. tfplugindocs generate --flags

How much impact is this issue causing?

Low

Logs

No response

Additional Information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[bflad]

Hi @komalkadam-dc 👋 Thank you for reporting this issue and sorry for the trouble here.

Looking at the internal logic, there is some special handling for id attributes and it seems like it does not take into account whether that id attribute is at the root of the schema or not. Root level id attributes were special in terraform-plugin-sdk and Terraform versions before 0.12, which is likely why this code was in here. Hopefully adding a quick root level check should resolve this. 👍

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.