Add tests for numbers.

Relies on hashicorp/terraform-plugin-go#85, which fixes a bug in using
`tftypes.Value.As` to convert to a *big.Float.

Author: paddycarver

go.mod

@@ -4,5 +4,5 @@ go 1.16
 
 require (
 	github.com/google/go-cmp v0.5.6
-	github.com/hashicorp/terraform-plugin-go v0.3.0
+	github.com/hashicorp/terraform-plugin-go v0.3.1-0.20210531205937-808fead526fc
 )

go.sum

@@ -31,8 +31,8 @@ github.com/google/go-cmp v0.5.6 h1:BKbKCqvP6I+rmFHt06ZmyQtvB8xAkWdhFyr0ZUNZcxQ=
 github.com/google/go-cmp v0.5.6/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
 github.com/hashicorp/go-hclog v0.0.0-20180709165350-ff2cf002a8dd/go.mod h1:9bjs9uLqI8l75knNv3lV1kA55veR+WUPSiKIWcQHudI=
 github.com/hashicorp/go-plugin v1.3.0/go.mod h1:F9eH4LrE/ZsRdbwhfjs9k9HoDUwAHnYtXdgmf1AVNs0=
-github.com/hashicorp/terraform-plugin-go v0.3.0 h1:AJqYzP52JFYl9NABRI7smXI1pNjgR5Q/y2WyVJ/BOZA=
-github.com/hashicorp/terraform-plugin-go v0.3.0/go.mod h1:dFHsQMaTLpON2gWhVWT96fvtlc/MF1vSy3OdMhWBzdM=
+github.com/hashicorp/terraform-plugin-go v0.3.1-0.20210531205937-808fead526fc h1:GOc748rJrcq68Zolqu8dJKREKl5n9nAj12mR38/pFrs=
+github.com/hashicorp/terraform-plugin-go v0.3.1-0.20210531205937-808fead526fc/go.mod h1:dFHsQMaTLpON2gWhVWT96fvtlc/MF1vSy3OdMhWBzdM=
 github.com/hashicorp/yamux v0.0.0-20180604194846-3520598351bb/go.mod h1:+NfK9FKeTrX5uv1uIXGdwYDTeHna2qgaIlx54MXqjAM=
 github.com/jhump/protoreflect v1.6.0/go.mod h1:eaTn3RZAmMBcV0fifFvlm6VHNz3wSkYyXYWUh7ymB74=
 github.com/kr/pretty v0.1.0 h1:L/CwN0zerZDmRFUapSPitk6f+Q3+0za1rQkzVuMiMFI=

types/number.go

@@ -46,23 +46,29 @@ func (n *Number) ToTerraformValue(_ context.Context) (interface{}, error) {
 
 // Equal returns true if `other` is a *Number and has the same value as `n`.
 func (n *Number) Equal(other attr.Value) bool {
-	o, ok := other.(*Number)
-	if !ok {
-		return false
-	}
 	if n == nil && other == nil {
 		return true
 	}
 	if n == nil || other == nil {
 		return false
 	}
+	o, ok := other.(*Number)
+	if !ok {
+		return false
+	}
 	if n.Unknown != o.Unknown {
 		return false
 	}
 	if n.Null != o.Null {
 		return false
 	}
-	return n.Value == o.Value
+	if n.Value == nil && o.Value == nil {
+		return true
+	}
+	if n.Value == nil || o.Value == nil {
+		return false
+	}
+	return n.Value.Cmp(o.Value) == 0
 }
 
 // SetTerraformValue updates the Number to match the contents of `val`.