Fix panic for Value.As(**big.Float). #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*big.Float is a pointer type that will never really appear as anything except a pointer. So when using code like this: ```go var foo *big.Float err := value.As(&foo) ``` the target of `As` is actually a **big.Float. But our code dereferences it and calls `As` on the target of the pointer, but the target of the pointer is actually a nil pointer. This code fixes that by instantiating a new value for the pointer to point to, setting the pointer to that, and then calling `As` on the new value.
paddycarver
force-pushed
the
paddy_fix_big_float
branch
from
33ea956 to
808fead
Compare
paddycarver
added a commit
to hashicorp/terraform-plugin-framework
that referenced
this pull request
May 31, 2021
Relies on hashicorp/terraform-plugin-go#85, which fixes a bug in using `tftypes.Value.As` to convert to a *big.Float.
kmoe
approved these changes
Jun 1, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*big.Float is a pointer type that will never really appear as anything
except a pointer. So when using code like this:
the target of
Asis actually a **big.Float. But our code dereferencesit and calls
Ason the target of the pointer, but the target of thepointer is actually a nil pointer.
This code fixes that by instantiating a new value for the pointer to
point to, setting the pointer to that, and then calling
Ason the newvalue.